fix(cli): make account store updates transactional - #747
Open
grandizzy wants to merge 6 commits into
Open
Conversation
Co-Authored-By: grandizzy <38490174+grandizzy@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
Contributor
|
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fb66c-1cab-748e-95c4-a70fdf739f43 Co-authored-by: Amp <amp@ampcode.com>
Contributor
|
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fb66c-1cab-748e-95c4-a70fdf739f43 Co-authored-by: Amp <amp@ampcode.com>
grandizzy
force-pushed
the
fix/accounts-store-lock
branch
from
July 31, 2026 13:17
5497702 to
bc3b328
Compare
jxom
marked this pull request as ready for review
August 3, 2026 05:49
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc3b328c52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fb66c-1cab-748e-95c4-a70fdf739f43 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fb66c-1cab-748e-95c4-a70fdf739f43 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fb66c-1cab-748e-95c4-a70fdf739f43 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent concurrent Accounts store writers from overwriting fresh
store.jsonstate or restoring retired access-key credentials.This complements tempoxyz/tempo#6965 by making the Accounts CLI filesystem adapter participate in the same
store.json.lockadvisory-lock protocol.Koffi provides access to BSD
flock, which Node does not expose natively, while supporting the Linux/macOS x64/arm64 targets required by wallet-cli.Changes
flockonstore.json.lockfor every filesystem mutation.store.jsononly after acquiring the lock.privateKey,handle, orkeyPair.Testing
vp test src/core/Store.test.ts src/cli/storage.test.ts --runtsc -b --noEmitpnpm buildstd::fs::File::lock()Follow-up
wallet-cli’s standalone
esbuild/@yao-pkg/pkgpipeline will need to stage and smoke-test the target-specific Koffi native addon for Linux and macOS x64/arm64 when it adopts this Accounts revision.Co-Authored-By: grandizzy 38490174+grandizzy@users.noreply.github.com
Prompted by: grandizzy