Skip to content

Trying to fix broken unit tests on main #8795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shivs11 merged 1 commit into from
Dec 11, 2025
Merged

Trying to fix broken unit tests on main #8795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions service/matching/user_data_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"sync/atomic"
"time"

"github.com/dgryski/go-farm"
enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/serviceerror"
"go.temporal.io/server/api/matchingservice/v1"
Expand Down Expand Up @@ -250,11 +249,7 @@ func (m *userDataManagerImpl) userDataFetchSource() (*tqid.NormalPartition, erro
}
// sticky queue can only be of workflow type as of now. but to be future-proof, we make sure
// change to workflow task queue here
wfTQ := normalQ.Family().TaskQueue(enumspb.TASK_QUEUE_TYPE_WORKFLOW)
// use hash of the sticky queue name to pick a consistent "parent"
partitions := m.config.NumReadPartitions()
partition := int(farm.Fingerprint32([]byte(m.partition.RpcName()))) % partitions
return wfTQ.NormalPartition(partition), nil
return normalQ.Family().TaskQueue(enumspb.TASK_QUEUE_TYPE_WORKFLOW).RootPartition(), nil
}

}
Expand Down
Loading