Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
77b8aa8
add RPC, add tests
Shivs11 Dec 8, 2025
b1cf752
make check better
Shivs11 Dec 8, 2025
973c2cd
[wip]: added method in history without cache
Shivs11 Dec 9, 2025
896eb17
Merge branch 'main' into ss/versioning-override-version-presence
Shivs11 Dec 9, 2025
8582c7e
basic tests added
Shivs11 Dec 10, 2025
f64bd66
add functional and unit tests
Shivs11 Dec 10, 2025
9fed5c5
change proto to have string instead of task queue
Shivs11 Dec 10, 2025
99fedcf
use existing helper
Shivs11 Dec 10, 2025
db5a117
Merge branch 'ss/matching-rpc-task-queue-in-version' into ss/versioni…
Shivs11 Dec 10, 2025
f6d5147
Merge branch 'main' into ss/matching-rpc-task-queue-in-version
Shivs11 Dec 10, 2025
ce656f8
fix breaking functional changes, use task queue string rather than ta…
Shivs11 Dec 10, 2025
9244313
fix other breaking functional tests
Shivs11 Dec 10, 2025
85caeba
changes
Shivs11 Dec 10, 2025
ae7aa05
place testTaskQueue name correctly
Shivs11 Dec 10, 2025
a156083
current draft
Shivs11 Dec 11, 2025
ac37b42
Merge branch 'main' into ss/versioning-override-version-presence
Shivs11 Dec 11, 2025
3b2ce45
cleanup
Shivs11 Dec 11, 2025
3142695
stop lint from complaining
Shivs11 Dec 11, 2025
85ea320
Merge branch 'main' into ss/matching-rpc-task-queue-in-version
Shivs11 Dec 11, 2025
87d61de
more lint complains
Shivs11 Dec 11, 2025
15f5080
add api in unit-test so that it does not fail
Shivs11 Dec 11, 2025
69b5291
Merge branch 'ss/matching-rpc-task-queue-in-version' into ss/versioni…
Shivs11 Dec 11, 2025
04e0490
remove non-required comment
Shivs11 Dec 11, 2025
040b210
Merge branch 'main' into ss/versioning-override-version-presence
Shivs11 Dec 11, 2025
c5153c7
Merge branch 'ss/versioning-override-version-presence' of github.com:…
Shivs11 Dec 11, 2025
d22b1f5
cursor comments
Shivs11 Dec 11, 2025
5c31e16
use shorter names in SA test to stop them from flaking
Shivs11 Dec 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions api/matchingservice/v1/request_response.go-helpers.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

696 changes: 410 additions & 286 deletions api/matchingservice/v1/request_response.pb.go

Large diffs are not rendered by default.

161 changes: 83 additions & 78 deletions api/matchingservice/v1/service.pb.go

Large diffs are not rendered by default.

39 changes: 39 additions & 0 deletions api/matchingservice/v1/service_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 35 additions & 0 deletions api/matchingservicemock/v1/service_grpc.pb.mock.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions client/matching/client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions client/matching/metric_client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions client/matching/retryable_client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions common/dynamicconfig/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -2667,6 +2667,12 @@ to the CHASM (V2) implementation on active scheduler workflows.`,
instead of the previous HSM backed implementation.`,
)

VersionMembershipCacheTTL = NewGlobalDurationSetting(
"history.versionMembershipCacheTTL",
1*time.Second,
`TTL for caching RPC results that check whether a version is present in a task queue.`,
)

// keys for worker

WorkerPersistenceMaxQPS = NewGlobalIntSetting(
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions common/testing/testvars/test_vars.go
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,14 @@ func (tv *TestVars) WithTaskQueue(taskQueue string) *TestVars {
return tv.cloneSetVal("task_queue", taskQueue)
}

func (tv *TestVars) WithDeploymentSeries(deploymentSeries string) *TestVars {
return tv.cloneSetVal("deployment_series", deploymentSeries)
}

func (tv *TestVars) WithBuildID(buildID string) *TestVars {
return tv.cloneSetVal("build_id", buildID)
}

func (tv *TestVars) WithTaskQueueNumber(n int) *TestVars {
return tv.cloneSetN("task_queue", n)
}
Expand Down
Loading
Loading