Standalone Activity List and Count ActivityExecutions #8789

dandavison · 2025-12-10T02:02:42Z

Implement standalone activity ListActivityExecutions and CountActivityExecutions.

Note

Implements list and count APIs for standalone activities, wiring CHASM visibility, adding search attributes/memo, status mappings, and supporting query aliasing; includes proto additions and comprehensive tests.

Frontend:
- Add ListActivityExecutions and CountActivityExecutions handlers using chasm.ListExecutions/CountExecutions and VisibilityManager context.
- Map list results to ActivityExecutionListInfo (incl. duration) and expose grouped counts.
- Validate start requests with unaliased SAs, then restore aliased SAs for visibility.
Activity Component:
- Implement VisibilitySearchAttributesProvider and VisibilityMemoProvider with new SAs: ActivityType, ActivityStatus, ActivityTaskQueue.
- Add memo payload activitypb.ActivityListMemo and status conversion helpers (InternalStatusToAPIStatus, internalStatusToRunState).
Proto/Gen:
- Define ActivityListMemo message and generated helpers.
Wiring (fx):
- Provide visibility.NewChasmVisibilityManager to frontend module; register component with SAs.
Query Resolution:
- Support alias ActivityId by mapping to WorkflowId in visibility queries.
Tests:
- Add end-to-end tests for listing, counting, grouping, custom SAs, and error cases.

^{Written by Cursor Bugbot for commit 4f365ba. This will update automatically on new commits. Configure here.}

chasm/lib/activity/activity.go

bergundy · 2025-12-11T20:32:49Z

chasm/lib/activity/activity.go

+const (
+	ActivityTypeSAAlias      = "ActivityType"
+	ActivityStatusSAAlias    = "ActivityStatus"
+	ActivityTaskQueueSAAlias = "ActivityTaskQueue"


Suggested change

ActivityTaskQueueSAAlias = "ActivityTaskQueue"

TaskQueueSAAlias = "TaskQueue"

Same here, it's just task queue.

bergundy · 2025-12-11T20:33:51Z

chasm/lib/activity/activity.go

 	"google.golang.org/protobuf/types/known/durationpb"
 	"google.golang.org/protobuf/types/known/timestamppb"
 )

+const (
+	ActivityTypeSAAlias      = "ActivityType"
+	ActivityStatusSAAlias    = "ActivityStatus"


Suggested change

ActivityStatusSAAlias = "ActivityStatus"

ActivityStatusSAAlias = "ExecutionStatus"

Use the same non-qualified name as workflows.

bergundy · 2025-12-11T20:35:43Z

chasm/lib/activity/activity.go

+	ActivityTypeSearchAttribute      = chasm.NewSearchAttributeKeyword(ActivityTypeSAAlias, chasm.SearchAttributeFieldKeyword01)
+	ActivityStatusSearchAttribute    = chasm.NewSearchAttributeKeyword(ActivityStatusSAAlias, chasm.SearchAttributeFieldLowCardinalityKeyword01)
+	ActivityTaskQueueSearchAttribute = chasm.NewSearchAttributeKeyword(ActivityTaskQueueSAAlias, chasm.SearchAttributeFieldKeyword02)


I would be totally okay if we didn't stutter here and omitted the Activity prefix from these variables. We're already in the activity package.

bergundy · 2025-12-11T20:36:49Z

chasm/lib/activity/frontend.go

+	if err != nil {
+		return nil, err
+	}
+	ctx = chasm.NewVisibilityManagerContext(ctx, h.visibilityManager)


This is something that we expect to be done in an interceptor. Please coordinate with @awln-temporal @lina-temporal and @rodrigozhou on this.

bergundy · 2025-12-11T20:39:51Z

chasm/lib/activity/frontend.go

@@ -238,6 +325,21 @@ func (h *frontendHandler) validateAndPopulateStartRequest(
 	}
 	applyActivityOptionsToStartRequest(opts, req)

+	// TODO: Unalias for validation, then restore aliased SA for CHASM visibility storage. The
+	// validator requires unaliased format but CHASM visibility expects aliased format.
+	originalSA := req.SearchAttributes


I would make validateAndNormalizeStartActivityExecutionRequest a method of the handler and unalias in there. Seems cleaner than mutating the request twice.

bergundy · 2025-12-11T20:42:40Z

common/persistence/visibility/store/query/resolve.go

@@ -38,6 +38,12 @@ func ResolveSearchAttributeAlias(
 			return sadefs.WorkflowID, saType, nil
 		}

+		// Handle ActivityId → WorkflowID transformation for standalone activities


Visibility team should fix the need to hardcode here eventually. Add a TODO.

bergundy · 2025-12-11T20:50:54Z

common/searchattribute/sadefs/constants.go

@@ -59,6 +59,8 @@ const (
 	// any other custom search attribute.
 	ScheduleID = "ScheduleId"

+	ActivityId = "ActivityId"


Same here, add a TODO to remove this hardcoded constant.

bergundy · 2025-12-11T20:52:23Z

tests/standalone_activity_test.go

+		customSAName := "ActivityCustomKeyword"
+		customSAValue := "custom-sa-test-value"
+
+		_, err := s.OperatorClient().AddSearchAttributes(ctx, &operatorservice.AddSearchAttributesRequest{


I think there's a set of custom search attributes already defined for all functional tests.

bergundy · 2025-12-11T20:55:06Z

tests/standalone_activity_test.go

+	})
+
+	t.Run("QueryByActivityStatus", func(t *testing.T) {
+		verifyListQuery(t, fmt.Sprintf("ActivityStatus = 'Scheduled' AND ActivityType = '%s'", activityType))


What's Scheduled? It's supposed Running as we have for ExecutionStatus for workflows (case sensitive?)

bergundy · 2025-12-11T20:58:35Z

tests/standalone_activity_test.go

+		s.Equal(activityID, exec.GetActivityId())
+		s.Equal(runID, exec.GetRunId())
+		s.Equal(activityType, exec.GetActivityType().GetName())
+		s.Equal(enumspb.ACTIVITY_EXECUTION_STATUS_RUNNING, exec.GetStatus())
+		s.NotNil(exec.GetScheduleTime())


Make sure you cover all of the fields of ActivityExecutionListInfo in this test.

cursor · 2025-12-11T21:14:08Z

chasm/lib/activity/frontend.go

+			ActivityId:           exec.BusinessID,
+			RunId:                exec.RunID,
+			ScheduleTime:         timestamppb.New(exec.StartTime),
+			CloseTime:            timestamppb.New(exec.CloseTime),


Bug: CloseTime incorrectly set to Unix epoch for running activities

CloseTime is unconditionally set using timestamppb.New(exec.CloseTime) for all activities, including running ones. When exec.CloseTime is a zero time.Time (for non-closed activities), timestamppb.New creates a timestamp representing Unix epoch (1970-01-01 00:00:00) instead of nil. The existing workflow visibility code at visibility_manager_impl.go only sets CloseTime when the execution status is not running. The activity list response will incorrectly show all running activities as having a CloseTime of 1970-01-01.

cursor · 2025-12-13T18:36:41Z

chasm/lib/activity/activity.go

+func (a *Activity) SearchAttributes(_ chasm.Context) []chasm.SearchAttributeKeyValue {
+	return []chasm.SearchAttributeKeyValue{
+		ActivityTypeSearchAttribute.Value(a.GetActivityType().GetName()),
+		ActivityStatusSearchAttribute.Value(a.GetStatus().String()),


Bug: ActivityStatus stores internal status instead of public API status

The SearchAttributes method stores the internal activity status string (e.g., "Scheduled", "Started") via a.GetStatus().String(), but the reviewer @bergundy noted this should match workflow behavior where ExecutionStatus stores the public API status ("Running"). This creates an inconsistency: users must query ActivityStatus = 'Scheduled' or ActivityStatus = 'Started' to find running activities, whereas for workflows they would query ExecutionStatus = 'Running'. The value stored should likely be InternalStatusToAPIStatus(a.GetStatus()).String() to match the public status shown in list responses.

dandavison force-pushed the saa-visibility branch 2 times, most recently from 601fb05 to 65cb249 Compare December 11, 2025 02:21

dandavison changed the title ~~Standalone Activity ListActivityExecutions~~ Standalone Activity List and Count ActivityExecutions Dec 11, 2025

dandavison force-pushed the saa-visibility branch 2 times, most recently from e349308 to dbdead0 Compare December 11, 2025 20:26

dandavison marked this pull request as ready for review December 11, 2025 20:26

dandavison requested review from a team as code owners December 11, 2025 20:26

dandavison requested review from awln-temporal, bergundy and fretz12 December 11, 2025 20:26

cursor bot reviewed Dec 11, 2025

View reviewed changes

chasm/lib/activity/activity.go Show resolved Hide resolved

chasm/lib/activity/activity.go Outdated Show resolved Hide resolved

dandavison force-pushed the saa-visibility branch from c06d36b to 155925e Compare December 11, 2025 20:52

bergundy reviewed Dec 11, 2025

View reviewed changes

cursor bot reviewed Dec 11, 2025

View reviewed changes

Implement ListActivityExecutions and CountActivityExecutions

4f365ba

dandavison force-pushed the saa-visibility branch from 083b015 to 4f365ba Compare December 13, 2025 18:30

cursor bot reviewed Dec 13, 2025

View reviewed changes

	ActivityTaskQueueSAAlias = "ActivityTaskQueue"
	TaskQueueSAAlias = "TaskQueue"

	ActivityStatusSAAlias = "ActivityStatus"
	ActivityStatusSAAlias = "ExecutionStatus"

Standalone Activity List and Count ActivityExecutions #8789

Are you sure you want to change the base?

Standalone Activity List and Count ActivityExecutions #8789

Uh oh!

Conversation

dandavison commented Dec 10, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot Dec 11, 2025

Choose a reason for hiding this comment

Bug: CloseTime incorrectly set to Unix epoch for running activities

Uh oh!

cursor bot Dec 13, 2025

Choose a reason for hiding this comment

Bug: ActivityStatus stores internal status instead of public API status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dandavison commented Dec 10, 2025 •

edited by cursor bot

Loading