Skip to content

Conversation

@rodrigozhou
Copy link
Contributor

@rodrigozhou rodrigozhou commented Dec 9, 2025

What changed?

Added metric to track number of inflight visibility tasks.

Why?

Help debug bottlenecks in the visibility task flow: task queue or bulk processor.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

@rodrigozhou rodrigozhou requested review from a team as code owners December 9, 2025 01:37
@yycptt
Copy link
Member

yycptt commented Dec 9, 2025

Can you provide some context for this metric? I mean it will limited by the visibility task gorouting pool size.

FWIW, we already have pending_tasks metric and can be scoped to visibility queue, though it's a histogram for pending task count across shards.

@rodrigozhou
Copy link
Contributor Author

rodrigozhou commented Dec 9, 2025

IIUC, pending_tasks included all tasks that were load into memory, ie., not only the tasks dispatched to the executor. I wanted to track tasks that are in the executor to check if we are exhausting the history.visibilityProcessorSchedulerWorkerCount value. Basically, help diagnose where the bottleneck is in visibility: task queue or bulk processor.

@rodrigozhou rodrigozhou force-pushed the rodrigozhou/vis-queue-metrics branch from 44f2c3d to f9291b5 Compare December 10, 2025 02:01
@rodrigozhou rodrigozhou force-pushed the rodrigozhou/vis-queue-metrics branch from f9291b5 to 1a5b5fa Compare December 10, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants