CHASM Visibility ListWorkflowExecutions ignore unregistered CHASM search attributes #8773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
requested changes
Dec 8, 2025
| tp, err := combinedTypeMap.GetType(name) | ||
| if err != nil { | ||
| // Silently ignore ErrInvalidName for unregistered chasm search attributes | ||
| if sadefs.IsChasmSearchAttribute(name) && errors.Is(err, searchattribute.ErrInvalidName) { |
Contributor
There was a problem hiding this comment.
The combinedTypeMap already contains the CHASM search attributes. Do you need to check IsChasmSearchAttribute here?
Contributor
Author
There was a problem hiding this comment.
yeah, since the chasm search search attributes are not registered when calling ListWorkflowExecutions.
Contributor
There was a problem hiding this comment.
Hm, in this case, isn't it better to check before calling combinedTypeMap.GetType?
Contributor
Author
There was a problem hiding this comment.
no, since the chasm search attribute could be registered, in which case we do want to try returning it. visibility store implementations are unified for ListWorkflowExecutions and ListChasmExecutions as of now.
rodrigozhou
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Silently ignore unregistered CHASM search attributes for SQL visibility store.
ES already ignores unregistered search attributes (custom or chasm).
Why?
ListWorkflowExecutions needs to succeed when querying on all TemporalNamespaceDivisions.
How did you test it?