Skip to content

Conversation

@yycptt
Copy link
Member

@yycptt yycptt commented Dec 5, 2025

What changed?

  • Use force deletion for chasm execution in namespace deletion
  • Add functional test for forcing deleting chasm executions
  • We have log for force deletion as well

Why?

  • DeleteWorkflowExecution API is an async graceful deletion api that only works for Workflow, but not other CHASM archetypes.
  • Upon namespace deletion we need to delete chasm executions as well and we can use force deletion to do it.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@yycptt yycptt requested review from a team as code owners December 5, 2025 23:21
}

if archetypeID == chasm.WorkflowArchetypeID {
// TODO: consider using ForceDeleteWorkflowExecution for workflow as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only used for namespace deletion? if true, then we should just use force delete here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to refactor force deletion api handle a bit though. Today it only does best effort deletion on history events, we will need a non best effort mode first and then switch to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants