Skip to content

Add WorkflowPause to namespace capabilities #8767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spkane31 wants to merge 6 commits into
base: main
Choose a base branch
from
+7 −3
Open

Add WorkflowPause to namespace capabilities #8767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf37f55
Add WorkflowPauseEnabled to namespace capabilities
spkane31 Dec 5, 2025
dab786e
adding another test, and a lot of debugging
spkane31 Dec 5, 2025
eb0e3b6
removing all my debugging
spkane31 Dec 5, 2025
ab487bb
reverting changes
spkane31 Dec 6, 2025
43d93f9
Merge branch 'main' of github.com:temporalio/temporal into spk/pause-…
spkane31 Dec 8, 2025
cc293e5
Merge branch 'main' of github.com:temporalio/temporal into spk/pause-…
spkane31 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ require (
go.opentelemetry.io/otel/sdk v1.34.0
go.opentelemetry.io/otel/sdk/metric v1.34.0
go.opentelemetry.io/otel/trace v1.34.0
go.temporal.io/api v1.58.1-0.20251128181858-703071215042
go.temporal.io/api v1.59.1-0.20251205215512-1b49af22324a
go.temporal.io/sdk v1.35.0
go.uber.org/fx v1.24.0
go.uber.org/mock v0.6.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,8 @@ go.opentelemetry.io/otel/trace v1.34.0 h1:+ouXS2V8Rd4hp4580a8q23bg0azF2nI8cqLYnC
go.opentelemetry.io/otel/trace v1.34.0/go.mod h1:Svm7lSjQD7kG7KJ/MUHPVXSDGz2OX4h0M2jHBhmSfRE=
go.opentelemetry.io/proto/otlp v1.5.0 h1:xJvq7gMzB31/d406fB8U5CBdyQGw4P399D1aQWU/3i4=
go.opentelemetry.io/proto/otlp v1.5.0/go.mod h1:keN8WnHxOy8PG0rQZjJJ5A2ebUoafqWp0eVQ4yIXvJ4=
go.temporal.io/api v1.58.1-0.20251128181858-703071215042 h1:44+nPe+rGhYUwA1oDi46rkXEYEVfoAxOmb0myvTm4Es=
go.temporal.io/api v1.58.1-0.20251128181858-703071215042/go.mod h1:iaxoP/9OXMJcQkETTECfwYq4cw/bj4nwov8b3ZLVnXM=
go.temporal.io/api v1.59.1-0.20251205215512-1b49af22324a h1:eGsL32R3c2rlc6v56XI+vNtUViPONS5kyXW2OPh3d0U=
go.temporal.io/api v1.59.1-0.20251205215512-1b49af22324a/go.mod h1:iaxoP/9OXMJcQkETTECfwYq4cw/bj4nwov8b3ZLVnXM=
go.temporal.io/sdk v1.35.0 h1:lRNAQ5As9rLgYa7HBvnmKyzxLcdElTuoFJ0FXM/AsLQ=
go.temporal.io/sdk v1.35.0/go.mod h1:1q5MuLc2MEJ4lneZTHJzpVebW2oZnyxoIOWX3oFVebw=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
1 change: 1 addition & 0 deletions service/frontend/namespace_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,6 +862,7 @@ func (d *namespaceHandler) createResponse(
AsyncUpdate: d.config.EnableUpdateWorkflowExecutionAsyncAccepted(info.Name),
ReportedProblemsSearchAttribute: numConsecutiveWorkflowTaskProblemsToTriggerSearchAttribute > 0,
WorkerHeartbeats: d.config.WorkerHeartbeatsEnabled(info.Name),
WorkflowPause: d.config.WorkflowPauseEnabled(info.Name),
},
SupportsSchedules: d.config.EnableSchedules(info.Name),
}
Expand Down
3 changes: 3 additions & 0 deletions service/frontend/namespace_handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,13 +384,15 @@ func (s *namespaceHandlerCommonSuite) TestCapabilities() {
s.True(resp.NamespaceInfo.Capabilities.AsyncUpdate)
s.True(resp.NamespaceInfo.Capabilities.ReportedProblemsSearchAttribute)
s.True(resp.NamespaceInfo.Capabilities.WorkerHeartbeats)
s.False(resp.NamespaceInfo.Capabilities.WorkflowPause)

// Second call: Override the default value of dynamic configs.
s.config.EnableEagerWorkflowStart = dc.GetBoolPropertyFnFilteredByNamespace(false)
s.config.EnableUpdateWorkflowExecution = dc.GetBoolPropertyFnFilteredByNamespace(false)
s.config.EnableUpdateWorkflowExecutionAsyncAccepted = dc.GetBoolPropertyFnFilteredByNamespace(false)
s.config.NumConsecutiveWorkflowTaskProblemsToTriggerSearchAttribute = dc.GetIntPropertyFnFilteredByNamespace(5)
s.config.WorkerHeartbeatsEnabled = dc.GetBoolPropertyFnFilteredByNamespace(false)
s.config.WorkflowPauseEnabled = dc.GetBoolPropertyFnFilteredByNamespace(true)

resp, err = s.handler.DescribeNamespace(context.Background(), &workflowservice.DescribeNamespaceRequest{
Namespace: "ns",
Expand All @@ -401,6 +403,7 @@ func (s *namespaceHandlerCommonSuite) TestCapabilities() {
s.False(resp.NamespaceInfo.Capabilities.AsyncUpdate)
s.True(resp.NamespaceInfo.Capabilities.ReportedProblemsSearchAttribute)
s.False(resp.NamespaceInfo.Capabilities.WorkerHeartbeats)
s.True(resp.NamespaceInfo.Capabilities.WorkflowPause)
}

func (s *namespaceHandlerCommonSuite) TestRegisterNamespace_WithOneCluster() {
Expand Down
Loading