Skip to content

fix typo in test getLocation Activity in hello_world_in_go #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rizkiamr
Copy link
Contributor

@rizkiamr rizkiamr commented Mar 4, 2025

Hi team,

I found a typo in the "Build a Temporal Application from scratch in Go" page, specifically in the "Write tests to ensure things work" section where the docs mentioned to the incorrect file name (src/mocha/activities.ts) and it should be mentioned activities_test.go.

To test the getLocation Activity, you use a similar approach. Add the following code to the src/mocha/activities.ts file:

@rizkiamr rizkiamr requested a review from a team as a code owner March 4, 2025 13:35
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 1:37pm

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@angelazhou32 angelazhou32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion!

@angelazhou32 angelazhou32 merged commit 834309d into temporalio:main Mar 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants