Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I made sure that the comments documenting the code were right.
Here it says defaults are (10ms wf task, 50ms activity task)
But on the workflowTaskSlotOptions is says there is no rampThrottle
which looking at the implementation, the right one is the one that says there is a 10ms throttle:
Why?
Looking at how to improve tuner configs, I saw that comments were wrong:
https://temporalio.slack.com/archives/C046BRWDV2R/p1745395666974519?thread_ts=1745334134.022959&cid=C046BRWDV2R
Checklist
Closes
How was this tested:
No tests needed
Any docs updates needed?
Not sure, don't think so.