Expose root execution info #1662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THardy98
force-pushed
the
expose_root_wf_exec
branch
from
8b3b991 to
688cd1c
Compare
THardy98
force-pushed
the
expose_root_wf_exec
branch
from
688cd1c to
c43beb4
Compare
antlai-temporal
approved these changes
Apr 24, 2025
packages/workflow/src/interfaces.ts
Outdated
Comment on lines
65
to
67
| /** | ||
| * Root Workflow info | ||
| */ |
There was a problem hiding this comment.
I think you want to be more descriptive here of what this is. For example, mention that if there is no parent it is undefined but in reality it means that a workflow is its own root. You can copy the comments that I made in my PR that were adapted from the API comments...
There was a problem hiding this comment.
Yeah that's entirely fair, pretty lackluster doc description from me. I've copied your comment, much nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Updated core
Expose root execution information from workflow description/execution info, and workflow info
Closes [Feature Request] Expose root workflow execution #1633
How was this tested:
Added test
Any docs updates needed?
Probably