Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade minimum protobuf version needed to 3.25 #213

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

cretz
Copy link
Member

@cretz cretz commented Feb 4, 2025

What was changed

Downgraded minimum protobuf version needed to 3.25. This is needed to interoperate with https://github.com/coinbase/temporal-ruby (along with coinbase/temporal-ruby#335 from that side)

@mjameswh
Copy link
Contributor

mjameswh commented Feb 6, 2025

What can go wrong with this in the future? Does that mean we will need to coordinate with coinbase's temporal-ruby's team whenever that dependency needs to be updated? And users will need to ensure they always have compatible versions of the two SDKs?

We probably can't do much about this, but that might need to be clarified in docs…

@cretz
Copy link
Member Author

cretz commented Feb 6, 2025

What can go wrong with this in the future? Does that mean we will need to coordinate with coinbase's temporal-ruby's team whenever that dependency needs to be updated? And users will need to ensure they always have compatible versions of the two SDKs?

No, we don't need to coordinate, this PR is just saying the minmum protobuf version we work with, we will work with all later if they upgrade. But coinbase Ruby SDK has not changed in this area in a long while, and we have a sample that would break if either side was no longer interoperable.

Really this specific issue is just because of a mistake I made setting the minimum google-protobuf dependency to a 3.x version that doesn't even exist.

@cretz cretz merged commit 5b34e03 into temporalio:main Feb 6, 2025
6 checks passed
@cretz cretz deleted the downgrade-grpc branch February 6, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants