Skip to content

Add retry_policy to activity Info #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ytaben
Copy link
Contributor

@ytaben ytaben commented Apr 22, 2025

What was changed

Add retry_policy to activity.Info class.
My understanding is that the information already comes in the proto message and the only downside is 'from_proto' call + memory.

Why?

We have had an increasingly common request to provide monitoring and alerting only on the final activity failure.
As it stands - the existing activity failure metric is reported on each attempt with no information to determine whether the failure is 'final'.

Note: While it is in theory possible to make a workflow interceptor - we would like the metric to be attributed to the actual activity service worker. It makes it easier to, for example, implement automated canary testing for the activity worker service that only uses final failure metrics.

We are also not able to take the approach of 'pass this info in activity args' since we want a framework centric approach.

Checklist

  1. Closes

  2. How was this tested:
    Unit tests passed locally
    TBD

  3. Any docs updates needed?
    IDEs should reflect the change automatically on upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant