Use ruff for linting #771
Open
Use ruff for linting #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this,
File "/Users/dan/src/temporalio/sdk-python/.venv/lib/python3.13/site-packages/setuptools/config/pyprojecttoml.py", line 55, in validate
raise ValueError(f"{error}\n{summary}") from None
ValueError: invalid pyproject.toml config: `project.license`.
configuration error: `project.license` must be valid exactly by one definition (2 matches found):
- keys:
'file': {type: string}
required: ['file']
- keys:
'text': {type: string}
required: ['text']
Don't understand why they are showing on this branch only under same versions as main: Python 3.13.1 mypy 1.4.1 (compiled: no)
As seen in pydantic-core
Do not use `--no-install-project`.
…dk_bridge/" This reverts commit c62cf00.
cretz
reviewed
Feb 18, 2025
| import tests.worker.workflow_sandbox.testmodules.invalid_module | ||
| pass |
| @@ -194,9 +194,9 @@ | |||
|
|
|||
| # gRPC is optional | |||
| try: | |||
| import grpc | |||
| import grpc # noqa # type: ignore | |||
There was a problem hiding this comment.
Just for my own curiosity, what was failing here that is requiring these two comments?
Comment on lines
+936
to
+937
| # TODO: wat | ||
| f(self, other) # type: ignore # noqa: F821 |
There was a problem hiding this comment.
I do not know what I was thinking here, but it's likely a bug. Would definitely welcome a test that covers this and fixes it to do what it is supposed to.
dandavison
force-pushed
the
maturin
branch
6 times, most recently
from
e89f5b2 to
bc54894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WISOTT
PR targets
maturinbranch #768