Skip to content

Remove Nexus deprecated APIs #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

Remove Nexus deprecated APIs #2081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
237db52
Remove Nexus deprecated APIs
bergundy Oct 17, 2025
ce34591
Add comment on nexus-operation-id field
bergundy Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions internal/internal_nexus_task_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,17 +246,12 @@ func (h *nexusTaskHandler) handleStartOperation(
}
}
token := t.OperationToken
//lint:ignore SA1019 this field might be set by users of older SDKs.
if t.OperationID != "" {
token = t.OperationID //lint:ignore SA1019 this field might be set by users of older SDKs.
}
return &nexuspb.Response{
Variant: &nexuspb.Response_StartOperation{
StartOperation: &nexuspb.StartOperationResponse{
Variant: &nexuspb.StartOperationResponse_AsyncSuccess{
AsyncSuccess: &nexuspb.StartOperationResponse_Async{
OperationToken: token,
OperationId: token,
Links: links,
},
},
Expand Down
5 changes: 1 addition & 4 deletions temporalnexus/operation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ func (o *workflowRunOperation[I, O]) Start(
nexus.AddHandlerLinks(ctx, handle.link())
return &nexus.HandlerStartOperationResultAsync{
OperationToken: handle.token(),
OperationID: handle.token(),
}, nil
}

Expand All @@ -204,7 +203,6 @@ func (o *workflowRunOperation[I, O]) Start(
nexus.AddHandlerLinks(ctx, handle.link())
return &nexus.HandlerStartOperationResultAsync{
OperationToken: handle.token(),
OperationID: handle.token(),
}, nil
}

Expand Down Expand Up @@ -323,8 +321,7 @@ func ExecuteUntypedWorkflow[R any](
nexusOptions.CallbackHeader = make(nexus.Header)
}

//lint:ignore SA1019 this field is expected to be populated by servers older than 1.27.0.
nexusOptions.CallbackHeader.Set(nexus.HeaderOperationID, encodedToken)
nexusOptions.CallbackHeader.Set("nexus-operation-id", encodedToken)
nexusOptions.CallbackHeader.Set(nexus.HeaderOperationToken, encodedToken)
internal.SetCallbacksOnStartWorkflowOptions(&startWorkflowOptions, []*common.Callback{
{
Expand Down