Allow overriding SideEffect name via options #2074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
djeer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added SideEffectWithOptions
Why?
We're using SideEffects a lot and from a user perspective it's very hard to navigate the workflow timeline when there are 10-20 side effects in a row. The only way to see what was called there is to check the payload and try to understand which method could return this payload. This PR allows to override "SideEffect" with a custom name, making our users very very happy.
Checklist
Closes SideEffects markers are very difficult to navigate in the timeline #2076
How was this tested:
We ran in this fork for some time, it's quite minor change, and everything works perfect.
Do we need to change it here? https://docs.temporal.io/develop/go/side-effects
Probably could be limited to this SDK scope.