Skip to content

feat: use Stringer in getFunctionName when available (ExecuteActivity) #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: use Stringer in getFunctionName when available (ExecuteActivity) #2050

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d6a33
feat: use Stringer in getFunctionName when available
LukaGiorgadze Sep 11, 2025
f12cfd3
check fmt.Stringer after the func pointer
LukaGiorgadze Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/internal_worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2069,6 +2069,9 @@ func isError(inType reflect.Type) bool {
}

func getFunctionName(i interface{}) (name string, isMethod bool) {
if s, ok := i.(fmt.Stringer); ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do decided to accept this change, I think we would have to check for fmt.Stringer after the function pointer check due to non determinism concerns.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, updated!

return s.String(), false
}
if fullName, ok := i.(string); ok {
return fullName, false
}
Expand Down