Change_log_level #187
Open
Change_log_level #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSmithApps
force-pushed
the
changle_log_level
branch
from
5cfa4c5 to
598c1af
Compare
cretz
reviewed
May 27, 2025
| return True | ||
|
|
||
|
|
||
| logging.getLogger("temporalio.worker._workflow_instance").addFilter(CustomLogFilter()) |
There was a problem hiding this comment.
Suggested change
| logging.getLogger("temporalio.worker._workflow_instance").addFilter(CustomLogFilter()) | |
| logging.getLogger().addFilter(CustomLogFilter()) |
Can we add this to the root logger instead (untested)? There are no guarantees about how we may refactor internals.
There was a problem hiding this comment.
May be able to add a test for this to confirm continued expected behavior (though I know we haven't always added tests for all samples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a hello sample showing how to change the log level for workflow task failures
Why?
Some users have requested a sample on this.
Checklist
Any docs updates needed?
Updated the top-level readme and the hello readme
How was this tested:
Ran and confirmed that the log level was changed to error