Allow log throttles to be configured per component #181
+247
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hehaifengcn
reviewed
Jan 7, 2026
| func (l *loggerProvider) Get(component LogComponentName) log.Logger { | ||
| logger, exists := l.loggers[component] | ||
| if !exists { | ||
| logger = l.root |
Collaborator
There was a problem hiding this comment.
so if component doesn't exist, then the default behavior is to use root which means always log right?
Contributor
Author
There was a problem hiding this comment.
Yes, though the default logger can be set with a throttle as well.
develop/old-config-with-TLS.yaml
Outdated
Comment on lines
77
to
82
| adminservice: | ||
| throttleMaxRPS: 10 | ||
| testexample: | ||
| throttleMaxRPS: 11 | ||
| adminstreams: | ||
| throttleMaxRPS: 12 |
Collaborator
There was a problem hiding this comment.
should we always config adminservice and adminstreams and treat logConfigs as overrides? this is to avoid adding these configs in all yaml files.
Contributor
Author
There was a problem hiding this comment.
Hm, yeah some defaults based on the old values is probably a good idea. I'll add a block in logging
develop/old-config-with-TLS.yaml
Outdated
| profiling: {} | ||
| logConfigs: | ||
| adminservice: | ||
| throttleMaxRPS: 10 |
Contributor
Author
There was a problem hiding this comment.
Yes, will update to demonstrate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new package
loggingand config maplogConfigs["component"]=LoggingConfig{}to allow log throttles to be configured per-component. Logging configs are referenced directly by name and may set the rate of logs or disable logs for that config. A config not explicitly set in the yaml falls back to the root logger.Why?
There have been many times when we've wanted to specify different log throttles for different kinds of logs, and as we did so we ended up creating multiple
throttledLogForXYZmembers. This allows a single place to easily configure log throttles, and to easily add and remove custom log configs as needed.