Pass all non-default flags #249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Behnke <[email protected]>
dnr
reviewed
Nov 1, 2025
workers/run.go
Outdated
| func passthrough(fs *pflag.FlagSet, prefix string) (flags []string) { | ||
| fs.Visit(func(f *pflag.Flag) { | ||
| fs.VisitAll(func(f *pflag.Flag) { | ||
| if f.DefValue == f.Value.String() { |
There was a problem hiding this comment.
ok, I see the problem, but I think using f.Changed would be better. does that work?
There was a problem hiding this comment.
Yup! works, too: Starting worker with command: [./program --task-queue omes-test --namespace=test]
Signed-off-by: Stephan Behnke <[email protected]>
dnr
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fixed a bug where explicitly set flags were not passed to the worker.
Before
After
Checklist
Closes
How was this tested: