Repository navigation
Use envconfig for tutorial clients - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
The workflow client and Worker now load connection settings through the official
@temporalio/envconfigpackage. Both explicitly retainlocalhost:7233and thedefaultNamespace when configuration values are absent, and the Worker closes its new native connection during shutdown.Temporal packages are aligned at the Node 18-compatible
~1.14.1release, and the README documents profile selection.Why?
The template previously relied only on implicit local defaults, so the Cloud profile created during onboarding was ignored. The SDK now owns profile selection, environment precedence, API-key authentication, TLS, and missing-profile errors; the template supplies only explicit local defaults.
This focused change supersedes #20 and #28.
Checklist
Closes: N/A
How was this tested:
npm install --package-lock-only --ignore-scriptsnpm run buildnpm run lintmise exec node@20 -- npm testnpx prettier --check README.md package.json src/client.ts src/worker.tsAny docs updates needed?