Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv + maturin migration #600

Merged
merged 11 commits into from
Feb 19, 2025
Merged

uv + maturin migration #600

merged 11 commits into from
Feb 19, 2025

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Feb 17, 2025

Migrate from poetry to uv. See temporalio/sdk-python#768

Tested via such commands as:

# with and without wheel at ../sdk-python/dist/*.whl
go run . run --lang python  --version ../sdk-python

go build -o temporal-features
./temporal-features run --version 1.9.0 --lang python continue_as_new/updates_do_not_block_continue_as_new

./temporal-features prepare --lang py --dir prepare-py --version ~/src/temporalio/sdk-python
./temporal-features run --prepared-dir prepare-py --server localhost:7233 --namespace default --lang python features/continue_as_new/updates_do_not_block_continue_as_new

./temporal-features build-image --lang python --version v1.9.0
docker run features:py-1.9.0 --lang py


@dandavison dandavison marked this pull request as ready for review February 18, 2025 03:08
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though leaving unapproved while the Python SDK main is not yet ready for this change

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note, if anyone is running .github/workflows/python.yaml with an existing tag and version-is-repo-ref as true, this will break for them. But I am not sure anyone is.

@dandavison
Copy link
Contributor Author

Note, if anyone is running .github/workflows/python.yaml with an existing tag and version-is-repo-ref as true, this will break for them. But I am not sure anyone is.

True. If needed we could make it work with both around https://github.com/temporalio/features/blob/uv/sdkbuild/python.go#L128-L135. E.g. inspect the pyproject.toml or try uv sync + build first and fallback to poetry install + build.

@dandavison dandavison merged commit 45350c7 into main Feb 19, 2025
21 checks passed
@dandavison dandavison deleted the uv branch February 19, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants