-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uv + maturin migration #600
Conversation
pyproject.toml migrated via `uvx migrate-to-uv`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though leaving unapproved while the Python SDK main
is not yet ready for this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note, if anyone is running .github/workflows/python.yaml
with an existing tag and version-is-repo-ref
as true
, this will break for them. But I am not sure anyone is.
True. If needed we could make it work with both around https://github.com/temporalio/features/blob/uv/sdkbuild/python.go#L128-L135. E.g. inspect the |
Migrate from poetry to uv. See temporalio/sdk-python#768
Tested via such commands as: