Skip to content

Conversation

bergundy
Copy link
Member

What changed?

Added first revision of APIs for standalone activities.

Missing API support for:

  • PauseActivity
  • UnpauseActivity
  • ResetActivity
  • UpdateActivityOptions

Notes for reviewers

  • See the open TODOs, some decisions need to be finalized.
  • Do we want to have an activity specific ID reuse policy and conflict policy or can we make this generic?
    • There are already other cases planned where we would want to use the same definitions.
  • Do we need a generic form of ActivityExecution? What would it be called? EntityExecution?
  • Does pause info need to be generic?
  • How does this integrate with versioning? Can the client specify any versioning constraints on the StartActivityExecutionRequest?
  • Do we want to use ActivityOptions in StartActivityExecutionRequest? Would more of the fields in the request be considered options in the future?

Server PR

Not done yet, this will be the next step.

ACTIVITY_EXECUTION_STATUS_UNSPECIFIED = 0;
// The activity is not in a terminal status. This does not necessarily mean that there is a currently running
// attempt. The activity may be backing off between attempts or waiting for a worker to pick it up.
ACTIVITY_EXECUTION_STATUS_RUNNING = 1;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will likely add a PAUSED status here since this is the direction workflow pause is going.

Missing API support for:

- [ ] PauseActivity
- [ ] UnpauseActivity
- [ ] ResetActivity
- [ ] UpdateActivityOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant