Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 7, 2025

Navigated workshop as student to identify problems. Found 17 issues ranging from critical blockers to polish gaps.

Documents Created

  • WORKSHOP_ISSUES_REPORT.md - 660-line technical analysis with root cause, impact, and fixes
  • ISSUES_SUMMARY.md - Executive summary with prioritized 4-phase action plan

Critical Issues (P0)

  1. Test suite broken - Imports from non-existent Python modules; solutions are notebooks
  2. Temporal setup unclear - Two methods documented (temporal_installation.ipynb vs make temporal-up) without clarity
  3. Exercise 3 markdown malformed - Nested code blocks, duplicate content

High Priority (P1)

  1. 132 lint errors (115 auto-fixable with ruff check . --fix)
  2. Exercise 2 missing UnsandboxedWorkflowRunner() - Solution has it, exercise doesn't
  3. No Exercise 4 tests - Exercises 1-3 have tests (broken), 4 has none
  4. Missing API key validation - Exercises 3-4 fail with cryptic OpenAI errors
  5. Handoff pattern underdocumented - Exercise 4 uses handoffs without explaining mechanics

Medium Priority (P2)

  1. No durability demonstration - Exercise 3 titled "Durable Agent" but doesn't show retries
  2. No Temporal UI guide - Links to UI without explaining what to look for
  3. NWS API reliability - Real API may be down/rate-limited; no fallback
  4. Activity timeouts undocumented - 30s timeouts used without explanation
  5. Bootstrap script outdated - References non-existent make exercise-1
  6. Installation notebook UX - Server start cell blocks indefinitely without explanation

Low Priority (Polish)

  1. README inconsistencies - Mixes notebook and terminal approaches
  2. Emoji compatibility - Heavy usage may not work in all terminals
  3. Missing EOF newlines - Several files

Investigation Method

make setup    # ✅ Dependencies install
make test     # ❌ All tests fail (import errors, syntax errors)
make lint     # ⚠️  132 errors (imports, f-strings, newlines)

Reviewed all notebooks, Exercise 4 files, bootstrap script, devcontainer config.

Positive Findings

Strong foundation: logical progression, clear TODOs, production patterns, real-world examples. Critical fixes will make workshop excellent.

Original prompt

This section details on the original issue you should resolve

<issue_title>Find any issues/problems/confusions with the workshop</issue_title>
<issue_description>Your objective is to navigate the workshop as a student and find any problems or confusing portions. Then report them.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 7, 2025
Copilot AI changed the title [WIP] Report issues and confusions found in workshop Document 17 workshop issues: broken tests, confusing setup, missing features Nov 7, 2025
Copilot AI requested a review from nadvolod November 7, 2025 20:21
Copilot finished work on behalf of nadvolod November 7, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find any issues/problems/confusions with the workshop

2 participants