-
-
Notifications
You must be signed in to change notification settings - Fork 138
feat(session): add redis session manager #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes!
Good questions, the kv-store doesn't support tagged configs yet but this should be the way to go if we want multiple database support. With a prefix I'd assume it'd be pretty safe to have sessions on the same database as the cache though, but I admit I don't know what are the best practices here |
|
For now I don't think we should widen the scope of this PR, and just assume one Redis instance. We can add tagged Redis configs later, but let's not complicate this PR with it. Apart from that, all looks fine! |
|
@innocenzi did you still have an open change request? |
Close #1700
Questions:
Laravel uses multiple configuration an treat redis as database, to separate cache from other things they configure multiple connections to different databases.
The Redis Client itself allows to set the prefix for the client as a whole. From my understanding to support that we need a tagged(
'session') redis client. I dont understand how to do that without touchung the kv-store.For example
RedisCacheConfig:The cache uses the same RedisConfig as the RedisSessionConfig and the data will be written in the same database.