fix: correct vote weight display units in ValidatorData card#890
Open
molty365 wants to merge 1 commit intotelosnetwork:masterfrom
Open
fix: correct vote weight display units in ValidatorData card#890molty365 wants to merge 1 commit intotelosnetwork:masterfrom
molty365 wants to merge 1 commit intotelosnetwork:masterfrom
Conversation
The 'Current Vote Weight' card was displaying the raw last_vote_weight value from the voters table without dividing by 10000, inflating the displayed number by 10,000x. This caused a visual mismatch where the vote weight showed e.g. '822,059.37 TLOS' when the actual weight is ~82.2 TLOS, while the boost chip correctly divided by 10000 showing '+822.0594 Boosted'. Reported by Prem (TelosIndiaBP) — boost appeared ~1000x smaller than expected relative to displayed vote weight.
✅ Deploy Preview for open-block-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for obe-testnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Current Vote Weight' card displays
last_vote_weightfrom the voters table without dividing by 10000, inflating the displayed number by 10,000x.Example (TelosIndiaBP):
822,059.37 TLOS82.2 TLOSvote weightThis also caused visual confusion with the self-stake boost chip, which correctly divides by 10000 — making the boost appear 1000x smaller than the displayed vote weight.
Fix: Add
/ 10000to the balance computation in ValidatorData.