chip accessibility fix #2332
chip accessibility fix #2332
Conversation
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| }; | ||
|
|
||
| handleChangeEvent = (event: MouseEvent | KeyboardEvent): void => { | ||
| if (this.disabled && this.type === 'dynamic') { |
There was a problem hiding this comment.
with this would the additional check on line 115 will still be needed?
There was a problem hiding this comment.
these are different checks, but I wanted to discuss with you this type dynamic anyway. i don't get it's meaning so I don't really get checks either
There was a problem hiding this comment.
I think it makes no logical sense we can discuss this.
no, it appeared to be the outdated snapshot. I've updated it, so you can retrigger pipeline, sorry. but it's also strange that i don't see command for it in package. i would also discuss tomorrow |
|
Dynamic Selection Standard version seems to stlil not be focusable |
|
@tshimber the |
my bad, forgot to run build here after prev fix. hopefully fixed now! could you run again please? |
tshimber
force-pushed
the
feature-chip-accessibility
branch
from
71840f0 to
45166e8
Compare
|
LGTM |
* ci: sets up docker compose alias for compatibility (#2342) * fix: dropdown scroll fixed (#2333) * chip accessibility fix (#2332) * feat: chip keyboard handling fixed * feat: chip html added * fix: snapshot updated * fix: focus issues fixed * fix: readme fix * checkbox and switch css fixes for high contrast mode (#2317) fix: checkbox and switch CSS fixes for high contrast mode * ghost btn in storybook (#2341) * fix: ghost btn in storybook fixed * fix: one more ghost fixed * event part in storybook fixed (#2345) * fix: event part in storybook fixed * fix: german versions fixed * aria details vs aria describedby fixed for text field (#2352) * refactor: aria details vs aria describedby fixed for text field * fix: reverted to ariaDetailedId + description added to storybook * chore(release): publish (#2354) * chore(release): publish --------- Co-authored-by: tshimber <[email protected]>
Fixes #2328
Chip keyboard handling fixed