Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav-item): hover underline on function slots #2260

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

felix-ico
Copy link
Collaborator

this should fix #2251

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 36c75dd
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/65a7f73de5466500089a0d7b
😎 Deploy Preview https://deploy-preview-2260--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amir-ba amir-ba added the bug Something isn't working label Aug 28, 2024
@tshimber
Copy link
Contributor

@felix-ico maybe you can comment on this PR?
I don't see any visual changes on hover in functions block in header, and in the #2251 you wrote that it's about scale-telekom-header-data-back-compat and is already fixed in version 147. maybe this was some draft PR?

@amir-ba amir-ba changed the title fix: hover underline fix(nav-item): hover underline on function slots Oct 23, 2024
@amir-ba
Copy link
Collaborator

amir-ba commented Oct 24, 2024

LGTM , I will merge this

@amir-ba amir-ba merged commit 6e8c380 into main Oct 24, 2024
12 checks passed
@amir-ba amir-ba deleted the fix/hover-underline branch October 24, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in icon navigation after scale update
3 participants