Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a vite react example #2204

Merged
merged 2 commits into from
Nov 29, 2023
Merged

docs: add a vite react example #2204

merged 2 commits into from
Nov 29, 2023

Conversation

felix-ico
Copy link
Collaborator

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit d9d47c5
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/655f9b22a718da0008f8cd69
😎 Deploy Preview https://deploy-preview-2204--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

acstll
acstll requested changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run build throws for me 😢

You think it's possible to fix without too much hustle?

image

@felix-ico
Copy link
Collaborator Author

@acstll should work now, i updated the dependencies but for some reason yarn still needs "resolutions" to work probperly.

acstll
acstll approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@felix-ico felix-ico merged commit c9fde04 into main Nov 29, 2023
11 checks passed
@felix-ico felix-ico deleted the docs/add-vite-react-example branch November 29, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acstll acstll acstll approved these changes

@maomaoZH maomaoZH Awaiting requested review from maomaoZH maomaoZH is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix-ico @acstll