Skip to content

Commit

Permalink
fix(telekom-header): prevent flicker that could make the footer unrea…
Browse files Browse the repository at this point in the history
…chable (#2230)

* fix: add fixed height on the base to prevent flicker

* style: format

---------

Co-authored-by: felixw <[email protected]>
  • Loading branch information
felix-ico and felixw authored Dec 11, 2023
1 parent 4911bbe commit 03cdd4c
Showing 1 changed file with 16 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
--font-weight-app-name: var(--telekom-typography-font-weight-extra-bold);

--_height: 60px;
--_base-height: 60px;
--_height-logo-svg: 36px;
--_height-bottom-bar: 60px;
--_height-top-bar: 0;
Expand Down Expand Up @@ -68,6 +69,8 @@
:host,
:host([scrolled-back]) {
--_height: 84px;
--_base-height: 84px;

--_height-logo-svg: 44px;
--_height-top-bar: 30px;
--_height-bottom-bar: 54px;
Expand Down Expand Up @@ -96,6 +99,7 @@
--telekom-spacing-composition-space-07
);
}

:host([type='slim'][scrolled]) {
--_spacing-right-bottom-app-name: var(
--telekom-spacing-composition-space-07
Expand All @@ -104,6 +108,7 @@
:host([type='slim']),
:host([scrolled]) {
--_height: 72px;

--_height-logo-svg: 40px;
--_height-top-bar: 0;
--_height-bottom-bar: 72px;
Expand All @@ -130,6 +135,8 @@
:host,
:host([scrolled-back]) {
--_height: 96px;
--_base-height: 96px;

--_height-logo-svg: 48px;
--_height-top-bar: 30px;
--_height-bottom-bar: 66px;
Expand All @@ -139,6 +146,8 @@

:host([type='slim']) {
--_height: 84px;
--_base-height: 84px;

--_height-logo-svg: 44px;
--_height-top-bar: 0;
--_height-bottom-bar: 84px;
Expand All @@ -163,6 +172,8 @@
:host,
:host([scrolled-back]) {
--_height: 120px;
--_base-height: 120px;

--_height-logo-svg: 60px;
--_height-top-bar: 30px;
--_height-bottom-bar: 90px;
Expand All @@ -181,6 +192,8 @@

:host([type='slim']) {
--_height: 96px;
--_base-height: 96px;

--_height-logo-svg: 48px;
--_height-top-bar: 0;
--_height-bottom-bar: 96px;
Expand All @@ -202,6 +215,7 @@

:host([type='slim'][scrolled]) {
--_height: 72px;

--_height-logo-svg: 40px;
--_height-top-bar: 0;
--_height-bottom-bar: 72px;
Expand Down Expand Up @@ -269,7 +283,8 @@ slot[name='functions'] {
}

[part~='base'] {
height: var(--_height);
/* height: var(--_height); */
height: var(--_base-height);
width: 100%;
transition: var(--transition-common-scrolled);
}
Expand Down

0 comments on commit 03cdd4c

Please sign in to comment.