chore: Update Mermaid library source to use CDN #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt14
temporarily deployed
to
package-build
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 3 3
Lines 524 524
Branches 94 94
=======================================
Hits 423 423
Misses 82 82
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test Results (windows)
|
Test Results (ubuntu)
tests/test_client.pytekhsi_client = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x7fa850dcfec0>
capsys = <_pytest.capture.CaptureFixture object at 0x7fa850c1d820>
instrument = True, sum_count = 5, sum_acq_time = 10.0, sum_data_rate = 50.0
expected_output = 'Average Update Rate:0.50, Data Rate:10.00Mbs'
@pytest.mark.parametrize(
("instrument", "sum_count", "sum_acq_time", "sum_data_rate", "expected_output"),
[
(True, 5, 10.0, 50.0, "Average Update Rate:0.50, Data Rate:10.00Mbs"),
],
)
def test_server_connection(
tekhsi_client: TekHSIConnect,
capsys: pytest.CaptureFixture[str],
instrument: bool,
sum_count: int,
sum_acq_time: float,
sum_data_rate: float,
expected_output: str,
) -> None:
"""Test the server connection using the TekHSI client.
Args:
tekhsi_client: An instance of the TekHSI client to be tested.
capsys (CaptureFixture): Pytest fixture to capture system output.
instrument: Whether the instrument is connected.
sum_count: The sum count.
sum_acq_time: The sum acquisition time.
sum_data_rate: The sum data rate.
expected_output: The expected output message.
"""
# Set the required attributes
tekhsi_client._instrument = instrument
tekhsi_client._sum_count = sum_count
tekhsi_client._sum_acq_time = sum_acq_time
tekhsi_client._sum_data_rate = sum_data_rate
# Set the verbose attribute to True
tekhsi_client.verbose = True
# Use the context manager to handle connection
> with tekhsi_client as connection:
capsys = <_pytest.capture.CaptureFixture object at 0x7fa850c1d820>
captured = CaptureResult(out='2025-09-17 17:33:36.000720 - enter()\n', err='')
connection = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x7fa850dcfec0>
expected_output = 'Average Update Rate:0.50, Data Rate:10.00Mbs'
instrument = True
request = name: "test_client"
response = status: CONNECTSTATUS_SUCCESS
sum_acq_time = 10.0
sum_count = 5
sum_data_rate = 50.0
tekhsi_client = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x7fa850dcfec0>
tests/test_client.py:58:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox/tests/lib/python3.12/site-packages/tekhsi/tek_hsi_connect.py:211: in __exit__
self.close()
exc_tb = None
exc_type = None
exc_val = None
self = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x7fa850dcfec0>
.tox/tests/lib/python3.12/site-packages/tekhsi/tek_hsi_connect.py:443: in close
self.force_sequence()
self = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x7fa850dcfec0>
.tox/tests/lib/python3.12/site-packages/tekhsi/tek_hsi_connect.py:500: in force_sequence
self.connection.RequestNewSequence(request)
request = name: "ba5c1edc-091e-4ba4-adff-3a16c9b91661"
self = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x7fa850dcfec0>
.tox/tests/lib/python3.12/site-packages/grpc/_channel.py:1181: in __call__
return _end_unary_response_blocking(state, call, False, None)
call = <grpc._cython.cygrpc.SegregatedCall object at 0x7fa850d2b4c0>
compression = None
credentials = None
metadata = None
request = name: "ba5c1edc-091e-4ba4-adff-3a16c9b91661"
self = <grpc._channel._UnaryUnaryMultiCallable object at 0x7fa850c39470>
state = <grpc._channel._RPCState object at 0x7fa850c1df10>
timeout = None
wait_for_ready = None
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
state = <grpc._channel._RPCState object at 0x7fa850c1df10>
call = <grpc._cython.cygrpc.SegregatedCall object at 0x7fa850d2b4c0>
with_call = False, deadline = None
def _end_unary_response_blocking(
state: _RPCState,
call: cygrpc.SegregatedCall,
with_call: bool,
deadline: Optional[float],
) -> Union[ResponseType, Tuple[ResponseType, grpc.Call]]:
if state.code is grpc.StatusCode.OK:
if with_call:
rendezvous = _MultiThreadedRendezvous(state, call, None, deadline)
return state.response, rendezvous
else:
return state.response
else:
> raise _InactiveRpcError(state) # pytype: disable=not-instantiable
E grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
E status = StatusCode.FAILED_PRECONDITION
E details = ""
E debug_error_string = "UNKNOWN:Error received from peer ipv6:%5B::1%5D:50312 {grpc_status:9, grpc_message:""}"
E >
call = <grpc._cython.cygrpc.SegregatedCall object at 0x7fa850d2b4c0>
deadline = None
state = <grpc._channel._RPCState object at 0x7fa850c1df10>
with_call = False
.tox/tests/lib/python3.12/site-packages/grpc/_channel.py:1009: _InactiveRpcError |
Test Results (macos)
tests/test_client.pytekhsi_client = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x10efffb30>
capsys = <_pytest.capture.CaptureFixture object at 0x10f917dd0>
instrument = True, sum_count = 5, sum_acq_time = 10.0, sum_data_rate = 50.0
expected_output = 'Average Update Rate:0.50, Data Rate:10.00Mbs'
@pytest.mark.parametrize(
("instrument", "sum_count", "sum_acq_time", "sum_data_rate", "expected_output"),
[
(True, 5, 10.0, 50.0, "Average Update Rate:0.50, Data Rate:10.00Mbs"),
],
)
def test_server_connection(
tekhsi_client: TekHSIConnect,
capsys: pytest.CaptureFixture[str],
instrument: bool,
sum_count: int,
sum_acq_time: float,
sum_data_rate: float,
expected_output: str,
) -> None:
"""Test the server connection using the TekHSI client.
Args:
tekhsi_client: An instance of the TekHSI client to be tested.
capsys (CaptureFixture): Pytest fixture to capture system output.
instrument: Whether the instrument is connected.
sum_count: The sum count.
sum_acq_time: The sum acquisition time.
sum_data_rate: The sum data rate.
expected_output: The expected output message.
"""
# Set the required attributes
tekhsi_client._instrument = instrument
tekhsi_client._sum_count = sum_count
tekhsi_client._sum_acq_time = sum_acq_time
tekhsi_client._sum_data_rate = sum_data_rate
# Set the verbose attribute to True
tekhsi_client.verbose = True
# Use the context manager to handle connection
> with tekhsi_client as connection:
capsys = <_pytest.capture.CaptureFixture object at 0x10f917dd0>
captured = CaptureResult(out='2025-09-17 17:33:32.000851 - enter()\n', err='')
connection = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x10efffb30>
expected_output = 'Average Update Rate:0.50, Data Rate:10.00Mbs'
instrument = True
request = name: "test_client"
response = status: CONNECTSTATUS_SUCCESS
sum_acq_time = 10.0
sum_count = 5
sum_data_rate = 50.0
tekhsi_client = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x10efffb30>
tests/test_client.py:58:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox/tests/lib/python3.12/site-packages/tekhsi/tek_hsi_connect.py:211: in __exit__
self.close()
exc_tb = None
exc_type = None
exc_val = None
self = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x10efffb30>
.tox/tests/lib/python3.12/site-packages/tekhsi/tek_hsi_connect.py:443: in close
self.force_sequence()
self = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x10efffb30>
.tox/tests/lib/python3.12/site-packages/tekhsi/tek_hsi_connect.py:500: in force_sequence
self.connection.RequestNewSequence(request)
request = name: "e05f55bf-fbd7-4114-98e4-3fc584a40b78"
self = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x10efffb30>
.tox/tests/lib/python3.12/site-packages/grpc/_channel.py:1181: in __call__
return _end_unary_response_blocking(state, call, False, None)
call = <grpc._cython.cygrpc.SegregatedCall object at 0x10fa4f500>
compression = None
credentials = None
metadata = None
request = name: "e05f55bf-fbd7-4114-98e4-3fc584a40b78"
self = <grpc._channel._UnaryUnaryMultiCallable object at 0x10f90d0f0>
state = <grpc._channel._RPCState object at 0x10f954410>
timeout = None
wait_for_ready = None
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
state = <grpc._channel._RPCState object at 0x10f954410>
call = <grpc._cython.cygrpc.SegregatedCall object at 0x10fa4f500>
with_call = False, deadline = None
def _end_unary_response_blocking(
state: _RPCState,
call: cygrpc.SegregatedCall,
with_call: bool,
deadline: Optional[float],
) -> Union[ResponseType, Tuple[ResponseType, grpc.Call]]:
if state.code is grpc.StatusCode.OK:
if with_call:
rendezvous = _MultiThreadedRendezvous(state, call, None, deadline)
return state.response, rendezvous
else:
return state.response
else:
> raise _InactiveRpcError(state) # pytype: disable=not-instantiable
E grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
E status = StatusCode.FAILED_PRECONDITION
E details = ""
E debug_error_string = "UNKNOWN:Error received from peer ipv6:%5B::1%5D:50312 {grpc_message:"", grpc_status:9}"
E >
call = <grpc._cython.cygrpc.SegregatedCall object at 0x10fa4f500>
deadline = None
state = <grpc._channel._RPCState object at 0x10f954410>
with_call = False
.tox/tests/lib/python3.12/site-packages/grpc/_channel.py:1009: _InactiveRpcError |
v12ganesh
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
chore: Update Mermaid library source to use CDN
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>