Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the timeout of GolangCILint workflow #965

Closed
wants to merge 1 commit into from
Closed

Increase the timeout of GolangCILint workflow #965

wants to merge 1 commit into from

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 13, 2025 •
edited
Loading

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 13, 2025
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 13, 2025
khrm
khrm commented Feb 13, 2025
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 13, 2025
@khrm khrm force-pushed the golangci-lint-actionTimeout branch from b7e81bf to 97356ea Compare February 13, 2025 05:58
@khrm khrm changed the title Increase the timeout duration to avoid test failures Remove the timeout from workflow to avoid test failures Feb 13, 2025
@khrm
Copy link
Contributor Author

khrm commented Feb 13, 2025

/kind misc

@khrm
Copy link
Contributor Author

khrm commented Feb 13, 2025

Refer: https://github.com/tektoncd/results/actions/runs/13295696368/job/37142966693?pr=964

This would fix these failures.

@khrm
Copy link
Contributor Author

khrm commented Feb 13, 2025

/assign @enarha @vdemeester

@khrm
Increase the timeout of GolangCILint workflow
1a0de9d 
This will avoid the timeout failures in test.
@khrm khrm force-pushed the golangci-lint-actionTimeout branch from 97356ea to 1a0de9d Compare February 13, 2025 06:02
@khrm khrm changed the title Remove the timeout from workflow to avoid test failures Increase the timeout of GolangCILint workflow Feb 13, 2025
@enarha
Copy link
Contributor

enarha commented Feb 13, 2025

/approve
/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 13, 2025
@vdemeester
Copy link
Member

/lgtm
/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enarha, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

@khrm this fails because of go 1.23. The workflow should install 1.23 instead of stable.

@khrm
Copy link
Contributor Author

khrm commented Feb 19, 2025

/close

@khrm khrm closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinal avinal Awaiting requested review from avinal

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

@enarha enarha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khrm @enarha @vdemeester @tekton-robot