Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Codeql for Results #963

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Configure Codeql for Results #963

wants to merge 3 commits into from

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 12, 2025

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 12, 2025
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2025
@khrm
Copy link
Contributor Author

khrm commented Feb 12, 2025

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 12, 2025
@khrm khrm force-pushed the khrm-patch-2 branch 2 times, most recently from 4434f22 to 38acf72 Compare February 12, 2025 15:42
@khrm
Copy link
Contributor Author

khrm commented Feb 13, 2025

/test pull-tekton-results-build-tests

@khrm
Copy link
Contributor Author

khrm commented Feb 13, 2025

/assign @vdemeester @afrittoli Please check why codeql fails.

@khrm
Copy link
Contributor Author

khrm commented Feb 13, 2025

/test pull-tekton-results-build-tests

@khrm
Copy link
Contributor Author

khrm commented Feb 13, 2025

Previous attempt to add CodeQl:
#494

@vdemeester vdemeester closed this Feb 13, 2025
@vdemeester vdemeester reopened this Feb 13, 2025
@vdemeester vdemeester closed this Feb 13, 2025
@vdemeester vdemeester reopened this Feb 13, 2025
@afrittoli
Copy link
Member

It looks like CodeQL is trying to use the make file, but the make file is broken.

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2025
@tekton-robot
Copy link

@khrm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-results-build-tests eaeaa8c link true /test pull-tekton-results-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants