-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Issue 9032 - Add support for step display name #9033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 9032 - Add support for step display name #9033
Conversation
6510629 to
fe8cd47
Compare
|
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Just a small comment about tests, otherwise it looks good.
|
@valAndre07 Thank you for this PR. Please make sure that all of your changes in the end are in one commit and you are following the commit message standards and are using conventional commit messages. https://github.com/tektoncd/community/blob/main/standards.md#commit-messages |
ac7bde9 to
daa90a3
Compare
|
@afrittoli @waveywaves Can I have some help to understand why these pipelines are failing ? 🙏 :
|
|
/retest |
|
@valAndre07 they might be "flaky" test 🙃 😓 |
|
/retest |
daa90a3 to
9a84f2e
Compare
b05705f to
24fa5bb
Compare
|
@waveywaves @vdemeester Can you help me understand why pipelines are failing ? I rebase my branch with main but still have errors 😢 |
As @vdemeester mentioned, we're currently struggling with some flaky tests, hopefully it will get better soon. In the meanwhile retesting may help. |
|
/retest |
1 similar comment
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @valAndre07! 👋 😸
Thank you for your contribution! 🥇
That is a useful thing. I have only a remark on the tests and a general question about validation.
Is there also an invalid displayName? Do we want to limit the length to 255 for example?
24fa5bb to
bdf1e6b
Compare
|
Hello @twoGiants 👋 About the invalid displayName, I couldn't find a rule about the length of the display name for tasks or another rule, so I went with the same idea. |
A step in a task is currently represented in the UI using a field (name). That is meant to be machine readable, not human readable. A new field displayName is added to Step.
bdf1e6b to
1af6229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @valAndre07
I just looked up the docs you linked and its actually saying:
The
displayNamemainly drives a better user experience and at the same time it is not validated for the content or length by the controller.
So we're good 😸 👍
/approve
/lgtm
/meow
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: twoGiants, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |

Changes
Before this commit, a step in a task is currently represented in the UI using a field (name) that is meant to be machine readable, not human readable. So new field are added to Step for display name.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes