Skip to content

Conversation

vishalanarase
Copy link

Changes

  • Moved mock data creation from pipelinerunresolution_test.go to
    pkg/reconciler/testing/factory.go, including:
    • ppipeline
    • ptspipelineTasks
    • newTaskRun() and related setup helpers
  • Moved status transformers to pkg/reconciler/testing/status_transformers.go:
    • makeSucceed(), withCanceled(), etc.
  • Moved selectors to pkg/reconciler/testing/selectors.go:
    • nopGetCustomRun, etc.
  • Renamed single-letter variables to descriptive names for clarity

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Resolves #8921

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 10, 2025
Copy link

linux-foundation-easycla bot commented Aug 10, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 10, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wlynch after the PR has been reviewed.
You can assign the PR to them by writing /assign @wlynch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/testing/factory.go Do not exist 0.0%
pkg/reconciler/testing/selectors.go Do not exist 0.0%
pkg/reconciler/testing/status_transformers.go Do not exist 0.0%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/testing/factory.go Do not exist 0.0%
pkg/reconciler/testing/selectors.go Do not exist 0.0%
pkg/reconciler/testing/status_transformers.go Do not exist 0.0%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/testing/factory.go Do not exist 0.0%
pkg/reconciler/testing/selectors.go Do not exist 0.0%
pkg/reconciler/testing/status_transformers.go Do not exist 0.0%

Signed-off-by: Vishal Anarase <[email protected]>
@tekton-robot
Copy link
Collaborator

The following Tekton test failed:

Test name Commit Details Required Rerun command
check-pr-has-kind-label b21b505 link true /test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/testing/factory.go Do not exist 0.0%
pkg/reconciler/testing/selectors.go Do not exist 0.0%
pkg/reconciler/testing/status_transformers.go Do not exist 0.0%

@waveywaves
Copy link
Member

/kind test

@tekton-robot
Copy link
Collaborator

@waveywaves: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

/kind test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@waveywaves
Copy link
Member

/kind test

@tekton-robot
Copy link
Collaborator

@waveywaves: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

/kind test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@waveywaves waveywaves added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 19, 2025
@waveywaves
Copy link
Member

/kind cleanup

@waveywaves
Copy link
Member

/retest

@waveywaves
Copy link
Member

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Aug 20, 2025
@waveywaves
Copy link
Member

/check-pr-has-kind-label

@waveywaves
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@waveywaves: No presubmit jobs available for tektoncd/pipeline@main

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@waveywaves
Copy link
Member

/kind misc

@jerop jerop removed their request for review September 12, 2025 18:54
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2025
@tekton-robot
Copy link
Collaborator

@vishalanarase: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/misc Categorizes issue or PR as a miscellaneuous one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Cleanup 🧹 pipelinerunresolution_test.go 🧹 and move mock data, status mutations and selectors to testing framework.

3 participants