-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(tests): move helpers to new testing framework structure #8957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor(tests): move helpers to new testing framework structure #8957
Conversation
Signed-off-by: Vishal Anarase <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
Signed-off-by: Vishal Anarase <[email protected]>
Signed-off-by: Vishal Anarase <[email protected]>
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Signed-off-by: Vishal Anarase <[email protected]>
The following is the coverage report on the affected files.
|
/kind test |
@waveywaves: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind test |
@waveywaves: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup |
/retest |
/kind misc |
/check-pr-has-kind-label |
/test check-pr-has-kind-label |
@waveywaves: No presubmit jobs available for tektoncd/pipeline@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind misc |
@vishalanarase: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
pkg/reconciler/testing/factory.go, including:
p
→pipeline
pts
→pipelineTasks
newTaskRun()
and related setup helpersmakeSucceed()
,withCanceled()
, etc.nopGetCustomRun
, etc.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
Resolves #8921