Remove default Artifacthub url override #3091

pratap0007 · 2025-12-12T04:28:37Z

This patch includes the following changes:

Remove the default Hub catalog configuration from the PAC settings before PAC SyncConfig function call as this is already handled by the PAC SyncConfig function
Remove the default ArtifactHub URL override, which is managed by PAC.
Update the transform test to align with PAC changes, hub_url should not be fetchable, and PAC will now set the catalog type to tektonhub.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Run make test lint before submitting a PR
Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

pratap0007 · 2025-12-12T04:36:22Z

I have verified fresh installation and upgrade with PAC PR , and it's working as expected.

mbpavan · 2025-12-12T07:56:16Z

/approve

tekton-robot · 2025-12-12T07:56:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbpavan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mbpavan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mbpavan · 2025-12-12T07:57:01Z

@zakisk and @jkhelil can you take a look please

pramodbindal · 2025-12-12T10:13:16Z

pkg/apis/operator/v1alpha1/openshiftpipelinesascode_defaults.go

 	}
-	defaultPacSettings := pacSettings.DefaultSettings()
+	defaultPacSettings := pacSettings.Settings{}
+


have that code been merged into PAC Which handles the default hub ?
Can you share that PR as well

openshift-pipelines/pipelines-as-code#2353 yet to be merged

@pramodbindal It is not merged yet, PAC PR: openshift-pipelines/pipelines-as-code#2353

then we should wait for that PR to merge first.
Once done we may need to upgrade the PAC dependency as well

@pramodbindal We can merge this PR as this is in the main branch and we will have to cherry pick it in release-v0.77.x branch
We will update PAC dependency in the releasev0.77.x branch only

anithapriyanatarajan · 2025-12-12T10:14:40Z

/kind bug

anithapriyanatarajan · 2025-12-13T07:52:12Z

@pratap0007 - Is there a need to revert the changes done for #3068

pratap0007 · 2025-12-13T08:29:34Z

@pratap0007 - Is there a need to revert the changes done for #3068

@anithapriyanatarajan I have included those change in this PR so there is no need to revert it

mbpavan · 2025-12-15T07:30:05Z

/cherry-pick release-v0.78.x

tekton-robot · 2025-12-15T07:30:38Z

❌ Cherry-pick to release-v0.78.x failed!

The automatic cherry-pick to release-v0.78.x failed.

Output:

🤖 Starting cherry-pick process...
Fetching PR #3091 information...
❌ ERROR: PR #3091 is not merged yet (state: OPEN). Cherry-pick requires merged PRs.

Next steps:

Check the action logs for complete details
If the PR is not merged, merge it first and try again
If there are conflicts, you'll need to manually cherry-pick this PR

pratap0007 · 2025-12-16T04:45:53Z

/unhold

pratap0007 · 2025-12-16T06:34:55Z

/retest

pratap0007 · 2025-12-16T12:43:40Z

/retest

anithapriyanatarajan · 2025-12-16T13:57:36Z

/retest

vdemeester · 2025-12-16T14:31:03Z

@anithapriyanatarajan @pratap0007 was the multi arch fixed in another PR ?

anithapriyanatarajan · 2025-12-16T14:37:21Z

@anithapriyanatarajan @pratap0007 was the multi arch fixed in another PR ?

Multiarch fixed with - #3106.

vdemeester · 2025-12-16T14:56:28Z

Then, this needs a rebase @pratap0007

This patch includes the following changes: - Remove the default Hub catalog configuration from the PAC settings before PAC SyncConfig function call as this is already handled by the PAC SyncConfig function - Remove the default ArtifactHub URL override, which is managed by PAC. - Update the transform test to align with PAC changes, hub_url should not be fetchable, and PAC will now set the catalog type to tektonhub. Signed-off-by: Shiv Verma <[email protected]>

Signed-off-by: Shiv Verma <[email protected]>

anithapriyanatarajan · 2025-12-16T18:20:32Z

/lgtm

tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 12, 2025

tekton-robot requested review from anithapriyanatarajan and piyush-garg December 12, 2025 04:28

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 12, 2025

pratap0007 force-pushed the remove-def-catalog branch from e74ba96 to 82f3ed5 Compare December 12, 2025 05:12

tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2025

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025

pramodbindal reviewed Dec 12, 2025

View reviewed changes

tekton-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 12, 2025

pratap0007 force-pushed the remove-def-catalog branch from 82f3ed5 to 2a2c70a Compare December 12, 2025 13:50

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2025

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2025

pratap0007 added 2 commits December 16, 2025 20:33

Bump openshift-pipelines/pipelines-as-code to v0.39.3

1a0443f

Signed-off-by: Shiv Verma <[email protected]>

pratap0007 force-pushed the remove-def-catalog branch from 228bf8f to 1a0443f Compare December 16, 2025 15:04

anithapriyanatarajan requested review from mbpavan and pramodbindal December 16, 2025 18:19

tekton-robot assigned anithapriyanatarajan Dec 16, 2025

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025

tekton-robot merged commit fa312f4 into tektoncd:main Dec 16, 2025
13 checks passed

Remove default Artifacthub url override #3091

Remove default Artifacthub url override #3091

Uh oh!

Conversation

pratap0007 commented Dec 12, 2025

Changes

Submitter Checklist

Release Notes

Uh oh!

pratap0007 commented Dec 12, 2025

Uh oh!

mbpavan commented Dec 12, 2025

Uh oh!

tekton-robot commented Dec 12, 2025

Uh oh!

mbpavan commented Dec 12, 2025

Uh oh!

pramodbindal Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

mbpavan Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

pratap0007 Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

pramodbindal Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

pramodbindal Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

pratap0007 Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

anithapriyanatarajan commented Dec 12, 2025

Uh oh!

anithapriyanatarajan commented Dec 13, 2025

Uh oh!

pratap0007 commented Dec 13, 2025

Uh oh!

mbpavan commented Dec 15, 2025

Uh oh!

tekton-robot commented Dec 15, 2025

Uh oh!

pratap0007 commented Dec 16, 2025

Uh oh!

pratap0007 commented Dec 16, 2025

Uh oh!

pratap0007 commented Dec 16, 2025

Uh oh!

anithapriyanatarajan commented Dec 16, 2025

Uh oh!

vdemeester commented Dec 16, 2025

Uh oh!

anithapriyanatarajan commented Dec 16, 2025

Uh oh!

vdemeester commented Dec 16, 2025

Uh oh!

anithapriyanatarajan commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants