Skip to content

Conversation

@cmorinupgrade
Copy link
Contributor

@cmorinupgrade cmorinupgrade commented Dec 10, 2025

Changes

Remove deprecated preserveUnknownFields field.

Reference: aws/amazon-vpc-cni-k8s#3487

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

Chart: Remove deprecated `preserveUnknownFields` field.

… quoting

- Move additionalEnvs configuration from root to operator section in values.yaml
- Update deployment template to reference operator.additionalEnvs
- Add quote wrapping for environment variable values to handle special characters
- Add descriptive comment for additionalEnvs configuration
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 10, 2025
@tekton-robot tekton-robot requested a review from mbpavan December 10, 2025 14:55
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign puneetpunamiya after the PR has been reviewed.
You can assign the PR to them by writing /assign @puneetpunamiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cmorinupgrade cmorinupgrade changed the title replace deprecated preserveUnknownFields annotation with x-kubernetes-preserve-unknown-fields replace deprecated preserveUnknownFields annotation with x-kubernetes-preserve-unknown-fields Dec 10, 2025
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2025
@cmorinupgrade cmorinupgrade changed the title replace deprecated preserveUnknownFields annotation with x-kubernetes-preserve-unknown-fields replace deprecated preserveUnknownFields field with x-kubernetes-preserve-unknown-fields Dec 10, 2025
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2025
@cmorinupgrade cmorinupgrade changed the title replace deprecated preserveUnknownFields field with x-kubernetes-preserve-unknown-fields remove deprecated preserveUnknownFields field Dec 10, 2025
@anithapriyanatarajan
Copy link
Contributor

@cmorinupgrade - Thanks for the PR. A few requests:

  1. Include base CRD updates: Please also remove the deprecated preserveUnknownFields: false field from the source CRD files in config/base/, config/kubernetes/base/, and config/openshift/base/ to keep them in sync with the Helm chart templates.
  2. Please verify: Helm upgrades work correctly (upgrade from previous version with preserveUnknownFields: false to new version without it) and make apply deploys successfully with the updated CRDs.

NIT: Consider adding to the PR description that this removes a field deprecated in favor of the x-kubernetes-preserve-unknown-fields annotation in the schema (which we already use correctly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants