-
Notifications
You must be signed in to change notification settings - Fork 231
remove deprecated preserveUnknownFields field
#3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… quoting - Move additionalEnvs configuration from root to operator section in values.yaml - Update deployment template to reference operator.additionalEnvs - Add quote wrapping for environment variable values to handle special characters - Add descriptive comment for additionalEnvs configuration
…tes-preserve-unknown-fields`
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
x-kubernetes-preserve-unknown-fieldspreserveUnknownFields annotation with x-kubernetes-preserve-unknown-fields
preserveUnknownFields annotation with x-kubernetes-preserve-unknown-fieldspreserveUnknownFields field with x-kubernetes-preserve-unknown-fields
preserveUnknownFields field with x-kubernetes-preserve-unknown-fieldspreserveUnknownFields field
|
@cmorinupgrade - Thanks for the PR. A few requests:
NIT: Consider adding to the PR description that this removes a field deprecated in favor of the |
Changes
Remove deprecated
preserveUnknownFieldsfield.Reference: aws/amazon-vpc-cni-k8s#3487
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRRelease Notes