Skip to content

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 10, 2025

Changes

This PR migrates the operator repository to use the centralized retest workflow from tektoncd/plumbing (addresses tektoncd/plumbing#3005).

What changed:

  • Replaced local 80+ line retest implementation with a simple workflow_call to the reusable workflow in plumbing
  • Reduces file from 83 lines to 15 lines
  • Uses tektoncd/plumbing/.github/workflows/_chatops_retest.yml@c9d6729a374829a3486b3b4a3c7c67d8b0926f04 (pinned to specific SHA)

Benefits:

  • Single source of truth for retest logic across all tektoncd repos
  • Easier to maintain (updates happen in plumbing, propagate everywhere)
  • Consistent behavior across repositories
  • Reduced code duplication

Testing:
No functional changes - the workflow behavior remains identical, it just delegates to the centralized implementation.

/kind misc

Submitter Checklist

  • Run make test lint before submitting a PR (N/A - workflow file only)
  • Includes tests (N/A - workflow file only)
  • Includes docs (comprehensive inline documentation retained)
  • Commit messages follow commit message best practices

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 10, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2025
@vdemeester vdemeester added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Dec 10, 2025
- Replace local 80+ line implementation with simple workflow_call
- Use centralized retest logic from tektoncd/plumbing
- Reduce maintenance burden and ensure consistent behavior
- File size reduced from 83 lines to 15 lines

Signed-off-by: Vincent Demeester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants