Fix: Pruner Config resetting to default when set to null #3078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
Contributor
|
/kind bug |
Contributor
|
/retest |
pratap0007
reviewed
Dec 10, 2025
When HistoryLimit is set to null in tektonconfig then it resets back to 100 After this fix value will be retained This also fisxes the issues ot pruner confog resetting to default on upgrade. Now after upgrade pruner should retain the old config
Contributor
|
/lgtm |
Contributor
|
@pramodbindal Attempt to upgrade from 0.77.x to the pr code base either results in pruner controller crashloop or configmap value not retained. Could you please assess the upgrade scenario once and confirm the outcome please. Thankyou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When HistoryLimit is set to null in tektonconfig then it resets back to 100
After this fix, value will be retained
This also fixes the issues of pruner config resetting to default on upgrade.
Now after upgrade pruner should retain the old config
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes