Skip to content

release-android-apk.yml interpolates app_root directly into run scripts #179

Description

@tehw0lf

Problem

release-android-apk.yml interpolates inputs.app_root directly into the run: scripts of the build apk, sign apk and align apk steps instead of passing it through env:. The value comes from the caller's own workflow file, so the risk is low, but it does not match the input-handling convention documented in CLAUDE.md.

Raised as a follow-up in the review of #178, which does not touch those lines.

What to do

Pass app_root to those steps through env: and reference the environment variable in the scripts, as the other workflows do for comparable inputs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions