Skip to content

⚡ Bolt: Avoid costly sqrt and use early exits in hot distance scans#113

Open
teerthsharma wants to merge 1 commit into
masterfrom
bolt-squared-distance-9981737551305813232
Open

⚡ Bolt: Avoid costly sqrt and use early exits in hot distance scans#113
teerthsharma wants to merge 1 commit into
masterfrom
bolt-squared-distance-9981737551305813232

Conversation

@teerthsharma
Copy link
Copy Markdown
Owner

💡 What: Replaced exact distance computation (libm::sqrt) with a squared distance comparison and early loop exit in ManifoldPoint::is_neighbor.
🎯 Why: SparseAttentionGraph::add_point uses is_neighbor in a hot O(N) spatial scan. Calculating full distances wastes cycles processing dimensions past the threshold and computing sqrt when points are already evidently beyond the epsilon radius.
📊 Impact: Speeds up spatial distance checks in high-dimensional or dense manifolds by avoiding floating-point sqrt operations and breaking out of calculation loops early.
🔬 Measurement: Verify correctness by running cargo test -p aether-core manifold, which tests points crossing thresholds.


PR created automatically by Jules for task 9981737551305813232 started by @teerthsharma

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant