Skip to content

⚡ Bolt: [performance improvement] O(N) K-Nearest Neighbors voting#109

Open
teerthsharma wants to merge 1 commit into
masterfrom
bolt-knn-select-unstable-14029399032835280077
Open

⚡ Bolt: [performance improvement] O(N) K-Nearest Neighbors voting#109
teerthsharma wants to merge 1 commit into
masterfrom
bolt-knn-select-unstable-14029399032835280077

Conversation

@teerthsharma
Copy link
Copy Markdown
Owner

💡 What: Replaced the $O(K \times N)$ partial bubble sort inside KNNClassifier::predict with slice::select_nth_unstable_by.
🎯 Why: Finding the top $K$ nearest neighbors previously sorted all distances partially, making it slow for large $K$ and $N$.
📊 Impact: Reduces nearest neighbor voting complexity from $O(K \times N)$ to $O(N)$ average time.
🔬 Measurement: Verify by checking the speed of KNNClassifier::predict with a large number of neighbors ($K$) and training points ($N$). Test suite continues to pass (with known exceptions).


PR created automatically by Jules for task 14029399032835280077 started by @teerthsharma

Co-authored-by: teerthsharma <78080953+teerthsharma@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant