-
Notifications
You must be signed in to change notification settings - Fork 166
Add more tex-output tests #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tex-output tests #1179
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1179 +/- ##
==========================================
+ Coverage 46.45% 46.99% +0.54%
==========================================
Files 176 176
Lines 65193 65196 +3
==========================================
+ Hits 30283 30639 +356
+ Misses 34910 34557 -353 ☔ View full report in Codecov by Sentry. |
So, @pkgw - I've discovered something fun, certain Linux configurations result in different output from all other platforms, including several other Linux configurations. I'll try to debug these at some point, but for now, would you prefer to hold off on merging these tests entirely, or just ignore the flaky one on Linux for now? |
b7f3696
to
ba3b523
Compare
Ugh. It looks like, most likely, somewhere between Harfbuzz 2.7 and 8 there was a change that affected how glyphs end up laid out in the buffer. Maybe a bugfix, maybe not, hard to say. Unfortunately, that means I don't think there's a nice way to 'fix' this - it's not our fault, but will likely become untested shortly when Ubuntu 24 becomes 'latest'. For now, I'll probably just try to ignore the tests on the bad platforms. |
6045876
to
7c6dc43
Compare
Test ignored on bad platforms for now - a bit overzealous of a cfg, but on the other hand, it's a test that just wasn't present before, so we're still gaining coverage by running it at least sometimes. And it should still identify bugs like it was originally designed to catch. |
7c6dc43
to
3037b2c
Compare
Tests that caught bugs in #1138. Also want to see if the Linux specific failures are happening on Master too, which will help me identify how to track them down.
Blocked on #1180