Skip to content

Add more tex-output tests #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

CraftSpider
Copy link
Contributor

@CraftSpider CraftSpider commented Mar 30, 2024

Tests that caught bugs in #1138. Also want to see if the Linux specific failures are happening on Master too, which will help me identify how to track them down.

Blocked on #1180

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.99%. Comparing base (1520823) to head (3037b2c).

Files Patch % Lines
...xetex_layout/layout/xetex-XeTeXLayoutInterface.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   46.45%   46.99%   +0.54%     
==========================================
  Files         176      176              
  Lines       65193    65196       +3     
==========================================
+ Hits        30283    30639     +356     
+ Misses      34910    34557     -353     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CraftSpider
Copy link
Contributor Author

So, @pkgw - I've discovered something fun, certain Linux configurations result in different output from all other platforms, including several other Linux configurations. I'll try to debug these at some point, but for now, would you prefer to hold off on merging these tests entirely, or just ignore the flaky one on Linux for now?

@CraftSpider
Copy link
Contributor Author

Ugh. It looks like, most likely, somewhere between Harfbuzz 2.7 and 8 there was a change that affected how glyphs end up laid out in the buffer. Maybe a bugfix, maybe not, hard to say. Unfortunately, that means I don't think there's a nice way to 'fix' this - it's not our fault, but will likely become untested shortly when Ubuntu 24 becomes 'latest'. For now, I'll probably just try to ignore the tests on the bad platforms.

@CraftSpider
Copy link
Contributor Author

Test ignored on bad platforms for now - a bit overzealous of a cfg, but on the other hand, it's a test that just wasn't present before, so we're still gaining coverage by running it at least sometimes. And it should still identify bugs like it was originally designed to catch.

@CraftSpider CraftSpider merged commit 19654bf into tectonic-typesetting:master Apr 17, 2024
29 checks passed
@CraftSpider CraftSpider deleted the output-tests branch April 17, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant