Update pages list UI #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pages list UI by refactoring the grid layout, enhancing styling, and introducing a custom domain display.
- Refactored the wrapper and item borders to support a responsive two-column layout with transition effects.
- Updated dark mode colors and hover transitions on page titles.
- Added display logic for a
custom_domainwith a fallback to<slug>.changes.pageand updated the server-side props query to includepage_settings.
Comments suppressed due to low confidence (1)
apps/web/pages/pages/index.tsx:161
- New display logic for
custom_domainvs. the slug fallback should be covered by tests; please add unit or integration tests to verify both scenarios render correctly.
{page.page_settings?.custom_domain
Comment on lines
+114
to
+120
| className={`relative group p-6 hover:bg-gray-50 dark:hover:bg-gray-800 cursor-pointer transition-colors duration-200 ${ | ||
| index < pages.length - 1 ? 'border-b border-gray-200 dark:border-gray-700' : '' | ||
| } ${ | ||
| index % 2 === 0 && index < pages.length - 2 ? 'sm:border-r sm:border-gray-200 sm:dark:border-gray-700' : '' | ||
| } ${ | ||
| index % 2 === 0 && index === pages.length - 2 && pages.length % 2 === 0 ? 'sm:border-r sm:border-gray-200 sm:dark:border-gray-700' : '' | ||
| }`} |
There was a problem hiding this comment.
[nitpick] Consider using a helper like clsx or classnames to compose these conditional classes instead of a long template string; it will improve readability and maintainability.
Suggested change
| className={`relative group p-6 hover:bg-gray-50 dark:hover:bg-gray-800 cursor-pointer transition-colors duration-200 ${ | |
| index < pages.length - 1 ? 'border-b border-gray-200 dark:border-gray-700' : '' | |
| } ${ | |
| index % 2 === 0 && index < pages.length - 2 ? 'sm:border-r sm:border-gray-200 sm:dark:border-gray-700' : '' | |
| } ${ | |
| index % 2 === 0 && index === pages.length - 2 && pages.length % 2 === 0 ? 'sm:border-r sm:border-gray-200 sm:dark:border-gray-700' : '' | |
| }`} | |
| className={classNames( | |
| "relative group p-6 hover:bg-gray-50 dark:hover:bg-gray-800 cursor-pointer transition-colors duration-200", | |
| { "border-b border-gray-200 dark:border-gray-700": index < pages.length - 1 }, | |
| { "sm:border-r sm:border-gray-200 sm:dark:border-gray-700": index % 2 === 0 && index < pages.length - 2 }, | |
| { "sm:border-r sm:border-gray-200 sm:dark:border-gray-700": index % 2 === 0 && index === pages.length - 2 && pages.length % 2 === 0 } | |
| )} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.