ROCC 494 push remote updates #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make rocc url configurable See merge request cedarville-university/sil/StoryProducer!2
…plementation things
I abstracted the displayName-fileName pairs into a Recording type. In addition; collections of files that have a selected file have been abstracted into a RecordingList. There were some files which I formatted while editing them, so this also added a large diff to this commit.
We don't need functions that perform a mapping over a list, but the only time it is called is to extract a single item out of the list.
…and removing audio
…ille-university/sil/StoryProducer into add-whole-story-backtranslation-phase
Also bundled into this commit is an improvement that saves the story json file whenever audio has finished recording. These two changes were accompanied by some cleaning up of code so that Workspace.activeSlideNum and Workspace.activeStory.lastSlideNum (as well as the analogous phase related variables) do not have to be kept in sync with each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.