Skip to content

TLS-RPT Support#82

Open
jnew-gh wants to merge 9 commits into
techsneeze:v2.0from
jnew-gh:v2.0
Open

TLS-RPT Support#82
jnew-gh wants to merge 9 commits into
techsneeze:v2.0from
jnew-gh:v2.0

Conversation

@jnew-gh

@jnew-gh jnew-gh commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

These commits add functionality to view SMTP TLS Reports (TLS-RPT) added into the main database by dmarcts-report-parser.

Four new files, tlsts-report-viewer.php, tlsts-report-viewer-report-list.php, tlsts-report-viewer-report-data.php and json.png, are created.

jnew-gh added 3 commits July 25, 2022 16:23
Create a new variable, report-type, to handle TLS Reports in addition to DMARC Reports
These files are, in large part, a copy/paste of the dmarcts- files, with necessary changes for the different structure of the TLS Reports.
Public domain icon json.png
@ekalin

ekalin commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Got this error when trying to view TLS reports with Postgres:

Uncaught PDOException: SQLSTATE[42883]: Undefined function: 7 ERROR: function year(timestamp without time zone) does not exist LINE 6: WHERE ((year(mindate) = 2022 AND month(mindate) = 7) OR (ye... ^ HINT: No function matches the given name and argument types. You might need to add explicit type casts. in /var/www/html/dmarcts-report-viewer/tlsts-report-viewer-report-list.php:268 Stack trace: #0 /var/www/html/dmarcts-report-viewer/tlsts-report-viewer-report-list.php(268): PDO->query('\nSELECT\n *\nFRO...') #1 {main} thrown in /var/www/html/dmarcts-report-viewer/tlsts-report-viewer-report-list.php on line 268

The problem seems to be that the year() function does not exist in Postgres, it must be extract(year from mindate) (and similarly for month), but this syntax is also valid MySQL, fortunately. See the changes I made for Postgres.

@jnew-gh

jnew-gh commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

These last 5 commits (from f0cedef on) add the green/yellow/red status icons to the TLS Report List and the ability to filter on the TLS Report status.

@brknkfr

brknkfr commented Oct 19, 2022

Copy link
Copy Markdown

Just tested TLS-RPT support. It seems to fork fine.

@wioxjk

wioxjk commented Oct 9, 2023

Copy link
Copy Markdown

Can we expect a merge soon?
@techsneeze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants