Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#11: Simplify configuration #12

Merged
merged 6 commits into from
Oct 14, 2023

Conversation

jeroenrnl
Copy link

@jeroenrnl jeroenrnl commented Jun 7, 2023

This change removes all the unchanged configuration items in config.local.php, so it's easier to spot what the differences are to the default config.
Then, at the end, it checks for a config.site.php and includes it if it exist. This way configuration changes can be made there instead of the default files, making changes easier to manage.

Issue #11

@jeroenrnl jeroenrnl changed the title Issue#3: Simplify configuration Issue#11: Simplify configuration Jun 7, 2023
This change removes all the unchanged configuration items in
`config.local.php`, so it's easier to spot what the differences are to
the default config.
Then, at the end, it checks for a `config.site.php` and includes it if
it exist. This way configuration changes can be made there instead of
the default files, making changes easier to manage.

Issue technicalguru#11
@jeroenrnl jeroenrnl force-pushed the simplify-configuration branch from 6ac5ea5 to 94fdda5 Compare June 7, 2023 19:05
@technicalguru technicalguru self-requested a review October 14, 2023 07:42
@technicalguru technicalguru changed the base branch from master to develop October 14, 2023 07:47
@technicalguru technicalguru merged commit f712ae8 into technicalguru:develop Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants