Skip to content

Add method to get service PID #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add method to get service PID #211

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f72125
Add method to return service pid
vinijabes Aug 19, 2020
d4bf8bb
Add check for existing proccess before returning pid
vinijabes Aug 19, 2020
db35d55
fix(pid): change invalid pid value
vinijabes Mar 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import (
"time"
)

const InvalidPid = -1

// ServiceOption configures a Service instance.
type ServiceOption func(*Service) error

Expand Down Expand Up @@ -164,6 +166,15 @@ func (s Service) FrameBuffer() *FrameBuffer {
return s.xvfb
}

//PID returns the service pid
func (s Service) PID() int {
if s.cmd != nil {
return s.cmd.Process.Pid
}

return InvalidPid
}

// NewSeleniumService starts a Selenium instance in the background.
func NewSeleniumService(jarPath string, port int, opts ...ServiceOption) (*Service, error) {
s, err := newService(exec.Command("java"), "/wd/hub", port, opts...)
Expand Down