Skip to content

fix(security): stop baking the ClickHouse password into the healthcheck command #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marselsel merged 1 commit into from
Aug 5, 2026
Merged

fix(security): stop baking the ClickHouse password into the healthcheck command #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,18 @@ services:
networks:
- backend
healthcheck:
test: ["CMD", "clickhouse-client", "--password", "${CLICKHOUSE_PASSWORD:-yavio_dev}", "--query", "SELECT 1"]
# Read the password from the container's own environment at run time
# rather than interpolating it here. Compose bakes an interpolated value
# into the container config, where `docker inspect` prints it in full —
# a live password was exposed that way on 2026-08-04 and had to be
# rotated. `$$` escapes to a literal `$`, so the shell inside the
# container expands it instead of compose.
#
# This does NOT hide the password from `docker inspect` entirely: the
# ClickHouse image needs CLICKHOUSE_PASSWORD in its environment to set
# the default user, so it remains visible under .Config.Env. What it
# removes is the second, easily-overlooked copy in the health command.
test: ["CMD-SHELL", "clickhouse-client --password \"$$CLICKHOUSE_PASSWORD\" --query 'SELECT 1'"]
interval: 5s
timeout: 5s
retries: 5
Expand Down
Loading