feat: Photographs can now be written on, stamped, and signed#902
Open
bruhmogus wants to merge 9 commits into
Open
feat: Photographs can now be written on, stamped, and signed#902bruhmogus wants to merge 9 commits into
bruhmogus wants to merge 9 commits into
Conversation
This reverts commit 0356810.
github-actions
Bot
added
S: Untriaged
S: Needs Review
size/XS
Changes: No C#
Changes: YML
Changes: Upstream
and removed
size/XS
S: Needs Review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why / Balance
I mean, it IS made of paper. Writing on photos can be good for describing the photo, since you can only take a photo of one thing at a time, and they aren't visual like in SS13. Signatures and stamps are also a good feature, for example if you want someone to autograph a photo of themselves for you.
Technical details
Adds a couple paper-related components to the base photograph, which of course will apply to all photograph types, which will be compatible with my super evil and fucked up flashless camera since they use the same entity.
Media
Changelog
🆑